[PATCH] D68386: [llvm-readobj] - Stop using a precompiled binary in all.test

Thu Oct 3 06:06:03 PDT 2019

grimar marked 2 inline comments as done.
grimar added a comment.

In D68386#1692779 <https://reviews.llvm.org/D68386#1692779>, @jhenderson wrote:

> You'll also want to update this test with an addrsig check at some point too.

Yeah, that is why I started doing this. I was under impression that no addrsig will be printed because there is no such section in a binary committed.
What I missed is that we always print something (tag name), even when there is no content to print. I am going to update the patch for addrsig.

================
Comment at: test/tools/llvm-readobj/all.test:2-3
+# RUN: yaml2obj %s -o %t.o
+# RUN: llvm-readobj -a %t.o | FileCheck %s -check-prefix ALL
+# RUN: llvm-readobj --all %t.o | FileCheck %s -check-prefix ALL

----------------
jhenderson wrote:
> Would you mind making these use double dashes for --check-prefix please?
Sure.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68386/new/

https://reviews.llvm.org/D68386