[PATCH] D68386: [llvm-readobj] - Stop using a precompiled binary in all.test

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 06:01:35 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one request. I think we need a GNU version of this test too, but that's probably a separate change.

You'll also want to update this test with an addrsig check at some point too.



================
Comment at: test/tools/llvm-readobj/all.test:2-3
+# RUN: yaml2obj %s -o %t.o
+# RUN: llvm-readobj -a %t.o | FileCheck %s -check-prefix ALL
+# RUN: llvm-readobj --all %t.o | FileCheck %s -check-prefix ALL
 
----------------
Would you mind making these use double dashes for --check-prefix please?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68386/new/

https://reviews.llvm.org/D68386





More information about the llvm-commits mailing list