[PATCH] D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 2 07:17:00 PDT 2019
fhahn accepted this revision.
fhahn added a comment.
Lgtm, with comments addressed, thanks
================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:541
+ return false;
+ BasicBlock *header = *Blocks.begin();
+ Function *F = header->getParent();
----------------
nit: variables usually are capitalized. Maybe the refactoring would be a good time to update them
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68331/new/
https://reviews.llvm.org/D68331
More information about the llvm-commits
mailing list