[PATCH] D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 06:40:39 PDT 2019


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with one suggestion



================
Comment at: llvm/include/llvm/Transforms/Utils/CodeExtractor.h:112
     /// Based on the blocks used when constructing the code extractor,
     /// determine whether it is eligible for extraction.
+    bool isEligible() const;
----------------
Update comment to mention varargs checking?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68331/new/

https://reviews.llvm.org/D68331





More information about the llvm-commits mailing list