[PATCH] D68081: Allow update_test_checks.py to not scrub names
David Greene via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 27 13:48:39 PDT 2019
greened added a comment.
In D68081#1686473 <https://reviews.llvm.org/D68081#1686473>, @reames wrote:
>
> This is not what an autogenerated test is. An auto-generated test includes the final state, and updating it is simply running the update script. We do not want to encourage customization of the output or manual workflows.
Well, that's pretty much the opposite of what the script says:
A common pattern is to have the script insert complete checking of every
instruction. Then, edit it down to only check the relevant instructions.
The script is designed to make adding checks to a test case fast, it is *not*
designed to be authoratitive about what constitutes a good test!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68081/new/
https://reviews.llvm.org/D68081
More information about the llvm-commits
mailing list