[PATCH] D68081: Allow update_test_checks.py to not scrub names

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D68081#1686308 <https://reviews.llvm.org/D68081#1686308>, @greened wrote:

> > I also don't see the value in this.  With autogenerated checks, the name of the instructions shouldn't be required to tell if the test is getting the correct behaviour and preserving the names makes test checks much more fragile.
>
> So here's the situation I ran into.  I have hundreds of tests to update.  I don't want to match all of the IR, just selected instructions.  The current behavior of rewriting the operands with FileCheck variable names makes it difficult to delete parts of the IR.  Maintaining the original names makes it easy to delete IR.


This is not what an autogenerated test is.  An auto-generated test includes the final state, and updating it is simply running the update script.  We do not want to encourage customization of the output or manual workflows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68081/new/

https://reviews.llvm.org/D68081