[PATCH] D67922: [Alignment][NFC] MaybeAlign in GVNExpression
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 27 01:54:52 PDT 2019
This revision was automatically updated to reflect the committed changes.
gchatelet marked an inline comment as done.
Closed by commit rL373054: [Alignment][NFC] MaybeAlign in GVNExpression (authored by gchatelet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D67922?vs=222092&id=222100#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67922/new/
https://reviews.llvm.org/D67922
Files:
llvm/trunk/include/llvm/Transforms/Scalar/GVNExpression.h
llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
Index: llvm/trunk/include/llvm/Transforms/Scalar/GVNExpression.h
===================================================================
--- llvm/trunk/include/llvm/Transforms/Scalar/GVNExpression.h
+++ llvm/trunk/include/llvm/Transforms/Scalar/GVNExpression.h
@@ -323,7 +323,7 @@
class LoadExpression final : public MemoryExpression {
private:
LoadInst *Load;
- unsigned Alignment;
+ MaybeAlign Alignment;
public:
LoadExpression(unsigned NumOperands, LoadInst *L,
@@ -333,7 +333,8 @@
LoadExpression(enum ExpressionType EType, unsigned NumOperands, LoadInst *L,
const MemoryAccess *MemoryLeader)
: MemoryExpression(NumOperands, EType, MemoryLeader), Load(L) {
- Alignment = L ? L->getAlignment() : 0;
+ if (L)
+ Alignment = MaybeAlign(L->getAlignment());
}
LoadExpression() = delete;
@@ -348,8 +349,8 @@
LoadInst *getLoadInst() const { return Load; }
void setLoadInst(LoadInst *L) { Load = L; }
- unsigned getAlignment() const { return Alignment; }
- void setAlignment(unsigned Align) { Alignment = Align; }
+ MaybeAlign getAlignment() const { return Alignment; }
+ void setAlignment(MaybeAlign Align) { Alignment = Align; }
bool equals(const Expression &Other) const override;
bool exactlyEquals(const Expression &Other) const override {
Index: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
+++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
@@ -1332,7 +1332,7 @@
E->setOpcode(0);
E->op_push_back(PointerOp);
if (LI)
- E->setAlignment(LI->getAlignment());
+ E->setAlignment(MaybeAlign(LI->getAlignment()));
// TODO: Value number heap versions. We may be able to discover
// things alias analysis can't on it's own (IE that a store and a
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67922.222100.patch
Type: text/x-patch
Size: 1848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190927/e20295ef/attachment.bin>
More information about the llvm-commits
mailing list