[PATCH] D67922: [Alignment][NFC] MaybeAlign in GVNExpression
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 27 01:00:58 PDT 2019
gchatelet marked 2 inline comments as done.
gchatelet added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/NewGVN.cpp:1335
if (LI)
- E->setAlignment(LI->getAlignment());
+ E->setAlignment(llvm::MaybeAlign(LI->getAlignment()));
----------------
fhahn wrote:
> `llvm::` should not be needed here either. I think in almost all contexts in `llvm/`, it should not be needed and probably should be removed in the patches already submitted as well.
I'll address this in a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67922/new/
https://reviews.llvm.org/D67922
More information about the llvm-commits
mailing list