[PATCH] D68062: Propeller lld framework for basicblock sections

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 20:39:39 PDT 2019


ruiu added inline comments.


================
Comment at: lld/ELF/Propeller.h:9-13
+// Propeller.h defines Propeller framework classes:
+//
+//   Propfile - parses and wraps propeller profile
+//
+//   Propeller - the main propeller framework class
----------------
This is too terse and can be understood only by those who knows what Propeller is/does. I want you to write something like this: https://github.com/llvm/llvm-project/blob/master/lld/ELF/ICF.cpp.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68062/new/

https://reviews.llvm.org/D68062





More information about the llvm-commits mailing list