[PATCH] D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2090-2091
     printSymbolTable(O, ArchiveName);
+  if (SectionContents)
+    printSectionContents(O);
+  if (Relocations && !Disassemble)
----------------
GNU objdump section contents appear after relocations in the version I'm using.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2094
+    printRelocations(O);
+  if (DynamicRelocations && !Disassemble)
+    printDynamicRelocations(O);
----------------
Is there a test case for this behaviour, i.e. suppressing -R output (also -r) when --disassemble is specified?


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2118
     printFaultMaps(O);
   if (DwarfDumpType != DIDT_Null) {
     std::unique_ptr<DIContext> DICtx = DWARFContext::create(*O);
----------------
Not sure if this is the right bit to comment on, but --dwarf=frames output for GNU objdump appears immediately after the symbol table, and llvm-objdump doesn't appear to be doing this currently, even with these changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68066/new/

https://reviews.llvm.org/D68066