[PATCH] D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht created this revision.
rupprecht added reviewers: jhenderson, justice_adams, grimar, ychen.
Herald added subscribers: llvm-commits, seiya.
Herald added a project: LLVM.

rL371826 <https://reviews.llvm.org/rL371826> rearranged some output from llvm-objdump for GNU objdump compatability, but there still seem to be some more.

I think this rearrangement is a little closer. A summary of the changes:

- File headers come after archive headers
- Section headers come immediately after file headers
- The symbol table comes in between section headers and section contents
- Relocations and disassembly comes after all those, and disassembly comes after relocations

Also: relocations aren't currently printed when disassemble is provided, but this check wasn't also included for dynamic relocations. Apply it there too.

Note: I have fixed existing tests, but haven't added any additional tests that existing ones don't catch. I'll update the patch with those later.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68066

Files:
  llvm/test/MC/COFF/symidx.s
  llvm/test/tools/llvm-objdump/X86/adjust-vma.test
  llvm/test/tools/llvm-objdump/X86/demangle.s
  llvm/test/tools/llvm-objdump/X86/out-of-section-sym.test
  llvm/test/tools/llvm-objdump/all-headers.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68066.221873.patch
Type: text/x-patch
Size: 8816 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190926/17ebecfd/attachment.bin>