[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added inline comments.


================
Comment at: lib/CodeGen/CodeGenFunction.cpp:899
+          CGM.getDiags().Report(diag::err_opt_not_valid_with_opt)
+            << "-mnop-mcount" << "-pg without -mfentry";
+        Fn->addFnAttr("mnop-mcount", "true");
----------------
jonpa wrote:
> uweigand wrote:
> > Why not use diag::err_opt_not_valid_without_opt here?
> yes, it seems needed, so I added it now in DiagnosticCommonKinds.td.
Ah, I still saw it in my tree, it was just removed as unused a week ago :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67763/new/

https://reviews.llvm.org/D67763