[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 02:02:00 PDT 2019


jonpa added inline comments.


================
Comment at: lib/CodeGen/CodeGenFunction.cpp:899
+          CGM.getDiags().Report(diag::err_opt_not_valid_with_opt)
+            << "-mnop-mcount" << "-pg without -mfentry";
+        Fn->addFnAttr("mnop-mcount", "true");
----------------
uweigand wrote:
> Why not use diag::err_opt_not_valid_without_opt here?
yes, it seems needed, so I added it now in DiagnosticCommonKinds.td.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67763/new/

https://reviews.llvm.org/D67763





More information about the llvm-commits mailing list