[PATCH] D68011: [RISCV] Split SP adjustment to reduce the offset of callee saved register spill and restore
Luís Marques via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 25 02:55:08 PDT 2019
luismarques added inline comments.
================
Comment at: lib/Target/RISCV/RISCVFrameLowering.h:49
+ // Determine to split the SP adjustment of prologue/epilogue.
+ bool isSplitSPAdjust(const MachineFunction &MF) const;
+
----------------
I'm not sure we need to split things into the boolean and the adjustment amount. Why not just have a single function, and if the returned initial adjustment is 0 then we just do the normal SP adjustment, otherwise we do it in two steps?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68011/new/
https://reviews.llvm.org/D68011
More information about the llvm-commits
mailing list