[PATCH] D67820: [LNT] Python 3 support: get rid of calls to cmp builtin

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with suggestion for a minor drive-by typo correction.



================
Comment at: lnt/server/db/testsuitedb.py:284
                 # SA occasionally uses comparison to check model instances
                 # verse some sentinels, so we ensure we support comparison
                 # against non-instances.
----------------
Minor drive-by: s/verse/versus/;


================
Comment at: tests/server/ui/test_api_modify.py:229
 if __name__ == '__main__':
-    unittest.TestLoader.sortTestMethodsUsing = lambda _, x, y: cmp(x, y)
     unittest.main(argv=[sys.argv[0], ])
----------------
thopre wrote:
> hubert.reinterpretcast wrote:
> > This does get called, but the default behavior is fine.
> What calls this lambda?
Something called through the call to `unittest.main` below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67820/new/

https://reviews.llvm.org/D67820