[PATCH] D67820: [LNT] Python 3 support: get rid of calls to cmp builtin

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lnt/server/db/testsuitedb.py:284
+
+                return (
+                    [
----------------
hubert.reinterpretcast wrote:
> Not sure what you think of this drive-by:
> ```
> next(
>     itertools.dropwhile(
>         lambda x: x[0] == x[1],
>         map(
>             lambda item:
>             (convert_revision(self.get_field(item), cache=Order.order_name_cache),
>              convert_revision(b.get_field(item), cache=Order.order_name_cache)),
>             self.fields)), (0, 0))
> ```
Went for intermediate steps as I find it more readable, YMMV.


================
Comment at: tests/server/ui/test_api_modify.py:229
 if __name__ == '__main__':
-    unittest.TestLoader.sortTestMethodsUsing = lambda _, x, y: cmp(x, y)
     unittest.main(argv=[sys.argv[0], ])
----------------
hubert.reinterpretcast wrote:
> This does get called, but the default behavior is fine.
What calls this lambda?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67820/new/

https://reviews.llvm.org/D67820