[PATCH] D67359: [IVUser] Limit the iterations to check whether a loop has dedicated exits for extreme large case

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 19:03:09 PDT 2019


skatkov added a comment.

The last thing. Would not you like to add a test examine the max-dedicate-exit-iterations functionality?

The test can use the small number for max-dedicate-exit-iterations and ensure that the function returns false? If it is difficult examine through opt you can probably write a unit test?
It seems it may protect you from future modification of this method.

If it is difficult or impossible to do -> lgtm.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67359/new/

https://reviews.llvm.org/D67359





More information about the llvm-commits mailing list