[PATCH] D67359: [IVUser] Limit the iterations to check whether a loop has dedicated exits for extreme large case

Tue Sep 24 10:38:54 PDT 2019

wmi added a comment.

In D67359#1680004 <https://reviews.llvm.org/D67359#1680004>, @xbolva00 wrote:

> In D67359#1679990 <https://reviews.llvm.org/D67359#1679990>, @wmi wrote:
>
> > In D67359#1679979 <https://reviews.llvm.org/D67359#1679979>, @xbolva00 wrote:
> >
> > > Probably just put it here:
> > >
> > > https://github.com/llvm/llvm-test-suite/tree/master/SingleSource/Regression/C
> >
> >
> > Thanks, I can put the test there, but I am not sure how large should I increase the size of the test to so it will definitely timeout without the patch, and do I need to consider the test takes different time to compile on different machines? I remember there is a fixed compile time limit to build a file in testsuite but I don't remember how long it is. Do you happen to know that?
>
>
> I dont know :( but 2s is probably okay. Maybe @fhahn can you help here..

I find the compile time limit in lnt nightly test is 500 seconds. To stably get time out without the patch, I estimate I need to increase the size of test so it takes > 30seconds to compile with the patch. I am not sure if that is ok.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67359/new/

https://reviews.llvm.org/D67359