[PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections
Jan Kratochvil via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 24 10:23:41 PDT 2019
jankratochvil added a comment.
In D67390#1681034 <https://reviews.llvm.org/D67390#1681034>, @kwk wrote:
> I wonder how to define uniqueness for them. As you can see, the only difference is the symbol section which wasn't part of your definition of uniqueness (yet).
These symbols should be obviously all kept distinct. Yes, you should add to the tuple also `ELFSymbol::st_shndx` as I have seen in your code: https://people.redhat.com/jkratoch/kwk-branch.diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67390/new/
https://reviews.llvm.org/D67390
More information about the llvm-commits
mailing list