[PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk added a comment.

@clayborg @labath I'm still trying to only add symbols when they are unique.

Take this already existing test:

  ./bin/llvm-lit -avv ~/llvm-project/lldb/lit/SymbolFile/DWARF/debug-types-line-tables.s

The symbols that are being added at the end of `ObjectFileELF::ParseSymbols` are  these:

  Symbol:
    i: 1
    start_id: 0
    symbol_bare: ""
    is_mangled: 0
    symbol_type: 0
    is_global: 0
    symbol_section_sp: 0x1915710 (.debug_str)
    symbol_value: 0
    symbol.st_size: 0
    symbol_size_valid: 1
    has_suffix: 0
    flags: 3
  
  Symbol:
    i: 2
    start_id: 0
    symbol_bare: ""
    is_mangled: 0
    symbol_type: 0
    is_global: 0
    symbol_section_sp: 0x19157e0 (.debug_abbrev)
    symbol_value: 0
    symbol.st_size: 0
    symbol_size_valid: 1
    has_suffix: 0
    flags: 3
  
  Symbol:
    i: 3
    start_id: 0
    symbol_bare: ""
    is_mangled: 0
    symbol_type: 0
    is_global: 0
    symbol_section_sp: 0x1915a50 (.debug_line)
    symbol_value: 0
    symbol.st_size: 0
    symbol_size_valid: 1
    has_suffix: 0
    flags: 3

I wonder how to define uniqueness for them. As you can see, the only difference is the symbol section which wasn't part of your definition of uniqueness (yet).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67390/new/

https://reviews.llvm.org/D67390