[PATCH] D67853: [PowerPC][XCOFF] Fix expansion of LWZtoc Pseudo for AIX.

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 07:42:20 PDT 2019


Xiangling_L accepted this revision.
Xiangling_L added a comment.
This revision is now accepted and ready to land.

Just a minor nit:

  clean up "local_unnamed_addr" in testcase? or even "dso_local"?



================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix-asm.ll:7
+
+define dso_local void @test() local_unnamed_addr {
+  %1 = load i32, i32* @b
----------------
Clean up this "local_unnamed_addr" as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67853/new/

https://reviews.llvm.org/D67853





More information about the llvm-commits mailing list