[PATCH] D67853: [PowerPC][XCOFF] Fix expansion of LWZtoc Pseudo for AIX.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 6 inline comments as done.
sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:652
   case PPC::LWZtoc: {
-    // Transform %r3 = LWZtoc @min1, %r2
+    // Transform %rN = LWZtoc @op1, %r2
     LowerPPCMachineInstrToMCInst(MI, TmpInst, *this, isDarwin);
----------------
Xiangling_L wrote:
> As you mentioned before, should we assert Darwin target is invalid for this toc-related pseudo? Something like:
> 
> ```
> assert (!isDarwin && "TOC is an ELF/XCOFF construct");
> ```
Good idea. Added.


================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix-asm.ll:4
+
+ at b = common dso_local local_unnamed_addr global i32 0, align 4
+ at a = common dso_local local_unnamed_addr global i32 0, align 4
----------------
Xiangling_L wrote:
> Personally, I prefer keep the testcase as minimal as possible, so maybe we can remove some attributes like:
> "local_unnamed_addr",
> "; Function Attrs: norecurse nounwind",
> "#0",
> "align 4" etc.
> 
Agreed. Cleaned up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67853/new/

https://reviews.llvm.org/D67853