[PATCH] D67461: lld-link: Make /linkrepro: take a filename, not a directory.

[Rui Ueyama via llvm-commits]

On Tue, Sep 24, 2019 at 4:49 AM Peter Collingbourne via Phabricator <
reviews at reviews.llvm.org> wrote:

> pcc added a comment.
>
> In D67461#1675640 <https://reviews.llvm.org/D67461#1675640>, @thakis
> wrote:
>
> > I realized why the behavior was different: link.exe has a /linkrepro:
> flag that behaves like lld-link's used to (
> https://www.geoffchappell.com/studies/msvc/link/link/options/linkrepro.htm?tx=37).
> It also honors a link_repro env var.
>
>
> Yes, that's why I originally made this take a directory instead of a file
> name.
>

Sorry, I should have remembered that.

> So I think I'll have to revert this, and add a comment explaining why
> things are different.
>
> I guess another option would be to rename this flag to `/lldlinkrepro`,
> which would let us implement link.exe-compatible behaviour under
> `/linkrepro` in the future.
>

I think I like that approach. It's also nice to have a comment describing
why we have two similar options, /linkrepro and /lldlinkrepro, to prevent
this from happening again.


>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67461/new/
>
> https://reviews.llvm.org/D67461
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190924/699ab29c/attachment.html>