<div dir="ltr"><div dir="ltr">On Tue, Sep 24, 2019 at 4:49 AM Peter Collingbourne via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">pcc added a comment.<br>
<br>
In D67461#1675640 <<a href="https://reviews.llvm.org/D67461#1675640" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67461#1675640</a>>, @thakis wrote:<br>
<br>
> I realized why the behavior was different: link.exe has a /linkrepro: flag that behaves like lld-link's used to (<a href="https://www.geoffchappell.com/studies/msvc/link/link/options/linkrepro.htm?tx=37" rel="noreferrer" target="_blank">https://www.geoffchappell.com/studies/msvc/link/link/options/linkrepro.htm?tx=37</a>). It also honors a link_repro env var.<br>
<br>
<br>
Yes, that's why I originally made this take a directory instead of a file name.<br></blockquote><div><br></div><div>Sorry, I should have remembered that.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> So I think I'll have to revert this, and add a comment explaining why things are different.<br>
<br>
I guess another option would be to rename this flag to `/lldlinkrepro`, which would let us implement link.exe-compatible behaviour under `/linkrepro` in the future.<br></blockquote><div><br></div><div>I think I like that approach. It's also nice to have a comment describing why we have two similar options, /linkrepro and /lldlinkrepro, to prevent this from happening again.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D67461/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67461/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D67461" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67461</a><br>
<br>
<br>
<br>
</blockquote></div></div>