[PATCH] D67937: Fix int to bool errors exposed due to r372612

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: compiler-rt/lib/builtins/fp_add_impl.inc:97
     if (align < typeWidth) {
-      const bool sticky = bSignificand << (typeWidth - align);
+      const bool sticky = ((bSignificand << (typeWidth - align)) != 0);
       bSignificand = bSignificand >> align | sticky;
----------------
rupprecht wrote:
> nit: I think there is an extra unnecessary set of parens, e.g.
> 
> ```
> const bool sticky = (bSignificand << (typeWidth - align)) != 0;
> ```
> 
> (same for the other cases)
+1, yes, please fix them


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67937/new/

https://reviews.llvm.org/D67937