[PATCH] D67937: Fix int to bool errors exposed due to r372612
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 23 16:02:50 PDT 2019
rupprecht added inline comments.
================
Comment at: compiler-rt/lib/builtins/fp_add_impl.inc:97
if (align < typeWidth) {
- const bool sticky = bSignificand << (typeWidth - align);
+ const bool sticky = ((bSignificand << (typeWidth - align)) != 0);
bSignificand = bSignificand >> align | sticky;
----------------
nit: I think there is an extra unnecessary set of parens, e.g.
```
const bool sticky = (bSignificand << (typeWidth - align)) != 0;
```
(same for the other cases)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67937/new/
https://reviews.llvm.org/D67937
More information about the llvm-commits
mailing list