[PATCH] D67872: gn build: Add build files for llvm/lib/Target/AVR

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 22 06:15:29 PDT 2019


thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/lib/Target/AVR/Disassembler/BUILD.gn:15
+    "//llvm/lib/Support",
+    "//llvm/lib/Target/AVR/MCTargetDesc",
+  ]
----------------
mbonadei wrote:
> I think we also need to add `//llvm/lib/Target/AVR/TargetInfo` and `//llvm/lib/Target/AVR:LLVMAVRCodeGen`.
Good catch, thanks! Done. At least Sparc and probably several other targets need something like this too; I'll do changes to existing targets in a follow-up.

(And maybe, one day, working `gn check`…)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67872/new/

https://reviews.llvm.org/D67872





More information about the llvm-commits mailing list