[PATCH] D67872: gn build: Add build files for llvm/lib/Target/AVR

Mirko Bonadei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 21 05:27:26 PDT 2019


mbonadei accepted this revision.
mbonadei added a comment.
This revision is now accepted and ready to land.

LGTM (only one comment about two possible missing deps).



================
Comment at: llvm/utils/gn/secondary/llvm/lib/Target/AVR/Disassembler/BUILD.gn:15
+    "//llvm/lib/Support",
+    "//llvm/lib/Target/AVR/MCTargetDesc",
+  ]
----------------
I think we also need to add `//llvm/lib/Target/AVR/TargetInfo` and `//llvm/lib/Target/AVR:LLVMAVRCodeGen`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67872/new/

https://reviews.llvm.org/D67872





More information about the llvm-commits mailing list