[PATCH] D67780: Can't pass .dSYM directory to llvm-objdump -dsym= (and error message is wrong)

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 20 09:36:06 PDT 2019


aprantl added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:7350
+        llvm::sys::path::replace_extension(ShortName, "");
+        Twine Path(DSYMPath + "/Contents/Resources/DWARF/" + ShortName);
+        DSYMPath = Path.str();
----------------
sys::path::append() is slightly more portable over hardcoding the path separators. Not sure if anyone would ever want to run this on Windows...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67780/new/

https://reviews.llvm.org/D67780





More information about the llvm-commits mailing list