[PATCH] D67780: Can't pass .dSYM directory to llvm-objdump -dsym= (and error message is wrong)

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 22:21:57 PDT 2019


MaskRay added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:7345
+
+      // if DSYMPath is a .dSYM directory, append the Mach-O file.
+      if (llvm::sys::fs::is_directory(DSYMPath) &&
----------------
if -> If


================
Comment at: tools/llvm-objdump/MachODump.cpp:7354
+
+      // load the file
       ErrorOr<std::unique_ptr<MemoryBuffer>> BufOrErr =
----------------
load -> Load. And append a full stop.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67780/new/

https://reviews.llvm.org/D67780





More information about the llvm-commits mailing list