[PATCH] D67795: [LNT] Python 3 support: Fix implicit package-relative imports

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: lnt/server/db/testsuite.py:117
     def from_json(data):
+        from . import testsuitedb
         if data.get('format_version') != '2':
----------------
thopre wrote:
> I have a slightly different patch that breaks the circular dependency altogether by moving some things from testsuitedb to testsuite. From what I read online it is a better approach, as people seems to suggest local import to break circular dependencies is more of a workaround. I have no opinion myself.
Thanks. I agree this is more of a workaround. I see that you posted D67811 and indicated that you're open to rebasing after this patch lands. I think the effect would be a reduction in the size of your patch (which would help make it easier to review), so I'll work on committing this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67795/new/

https://reviews.llvm.org/D67795