[PATCH] D67795: [LNT] Python 3 support: Fix implicit package-relative imports
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 20 01:23:18 PDT 2019
thopre added inline comments.
================
Comment at: lnt/server/db/testsuite.py:117
def from_json(data):
+ from . import testsuitedb
if data.get('format_version') != '2':
----------------
I have a slightly different patch that breaks the circular dependency altogether by moving some things from testsuitedb to testsuite. From what I read online it is a better approach, as people seems to suggest local import to break circular dependencies is more of a workaround. I have no opinion myself.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67795/new/
https://reviews.llvm.org/D67795
More information about the llvm-commits
mailing list