[llvm] r372366 - Use getTargetConstant for BLENDI, and add a test to catch it.

[Craig Topper via llvm-commits]

This test has no RUN line and is in a weird directory

On Thu, Sep 19, 2019 at 7:27 PM Sterling Augustine via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: saugustine
> Date: Thu Sep 19 19:29:16 2019
> New Revision: 372366
>
> URL: http://llvm.org/viewvc/llvm-project?rev=372366&view=rev
> Log:
> Use getTargetConstant for BLENDI, and add a test to catch it.
>
> Summary: This fixes a crasher introduced by r372338.
>
> Reviewers: echristo, arsenm
>
> Subscribers: jvesely, wdng, nhaehnle, hiraditya, llvm-commits
>
> Tags: #llvm
>
> Differential Revision: https://reviews.llvm.org/D67785
>
> Tighten up the test case.
>
> Added:
>
> llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll
> Modified:
>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=372366&r1=372365&r2=372366&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Thu Sep 19 19:29:16 2019
> @@ -17608,7 +17608,7 @@ SDValue X86TargetLowering::LowerINSERT_V
>          // operand form.
>          N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);
>          return DAG.getNode(X86ISD::BLENDI, dl, VT, N0, N1,
> -                           DAG.getConstant(1, dl, MVT::i8));
> +                           DAG.getTargetConstant(1, dl, MVT::i8));
>        }
>        // Create this as a scalar to vector..
>        N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);
>
> Added:
> llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll?rev=372366&view=auto
>
> ==============================================================================
> ---
> llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll
> (added)
> +++
> llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll
> Thu Sep 19 19:29:16 2019
> @@ -0,0 +1,14 @@
> +; ModuleID = 'bugpoint-reduced-simplified.bc'
> +target datalayout =
> "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
> +target triple = "x86_64-grtev4-linux-gnu"
> +
> +define dso_local void @csrot_(float* %0) local_unnamed_addr #0 align 32 {
> +1:
> +  %2 = load float, float* %0, align 4
> +  %3 = fsub float -0.000000e+00, %2
> +  %4 = insertelement <2 x float> <float undef, float -0.000000e+00>,
> float %3, i32 0
> +  store <2 x float> %4, <2 x float>* undef, align 8
> +  ret void
> +}
> +
> +attributes #0 = {
> "target-features"="+aes,+cx8,+fxsr,+mmx,+pclmul,+popcnt,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87"
> }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190919/10d2e7da/attachment.html>