<div><div dir="auto">This test has no RUN line and is in a weird directory</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 19, 2019 at 7:27 PM Sterling Augustine via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: saugustine<br>
Date: Thu Sep 19 19:29:16 2019<br>
New Revision: 372366<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=372366&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=372366&view=rev</a><br>
Log:<br>
Use getTargetConstant for BLENDI, and add a test to catch it.<br>
<br>
Summary: This fixes a crasher introduced by r372338.<br>
<br>
Reviewers: echristo, arsenm<br>
<br>
Subscribers: jvesely, wdng, nhaehnle, hiraditya, llvm-commits<br>
<br>
Tags: #llvm<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D67785" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67785</a><br>
<br>
Tighten up the test case.<br>
<br>
Added:<br>
    llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=372366&r1=372365&r2=372366&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=372366&r1=372365&r2=372366&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Thu Sep 19 19:29:16 2019<br>
@@ -17608,7 +17608,7 @@ SDValue X86TargetLowering::LowerINSERT_V<br>
         // operand form.<br>
         N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);<br>
         return DAG.getNode(X86ISD::BLENDI, dl, VT, N0, N1,<br>
-                           DAG.getConstant(1, dl, MVT::i8));<br>
+                           DAG.getTargetConstant(1, dl, MVT::i8));<br>
       }<br>
       // Create this as a scalar to vector..<br>
       N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);<br>
<br>
Added: llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll?rev=372366&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll?rev=372366&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll (added)<br>
+++ llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/isel-blendi-gettargetconstant.ll Thu Sep 19 19:29:16 2019<br>
@@ -0,0 +1,14 @@<br>
+; ModuleID = 'bugpoint-reduced-simplified.bc'<br>
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"<br>
+target triple = "x86_64-grtev4-linux-gnu"<br>
+<br>
+define dso_local void @csrot_(float* %0) local_unnamed_addr #0 align 32 {<br>
+1:<br>
+  %2 = load float, float* %0, align 4<br>
+  %3 = fsub float -0.000000e+00, %2<br>
+  %4 = insertelement <2 x float> <float undef, float -0.000000e+00>, float %3, i32 0<br>
+  store <2 x float> %4, <2 x float>* undef, align 8<br>
+  ret void<br>
+}<br>
+<br>
+attributes #0 = { "target-features"="+aes,+cx8,+fxsr,+mmx,+pclmul,+popcnt,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87" }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">~Craig</div>