[PATCH] D67556: [ARM][AArch64][DebugInfo] Improve call site instruction interpretation

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 19 04:01:03 PDT 2019


dstenb added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:682-684
+        // TODO: Add support for entry value plus an expression.
+        } else if (ShouldTryEmitEntryVals &&
+                   ParamValue->second->getNumElements() == 0) {
----------------
Any sense of what it would take to add support for such entry values? Would it be enough to store the expression alongside the new register in the work list, and then concatenate the two expressions when finding an instruction that describes the new register? Or must we consider how the expressions look in some way?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67556/new/

https://reviews.llvm.org/D67556





More information about the llvm-commits mailing list