[PATCH] D67736: [WebAssembly] Sort output data sections to place .bss last

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lld/wasm/Writer.cpp:690
+                     }
+                     llvm_unreachable("Unexpected segment name");
+                   });
----------------
sbc100 wrote:
> sbc100 wrote:
> > Its possible to have custom segment names.    See Writer.cpp:getOutputDataSegmentName.   Seems strange that no tests use this feature though .. maybe I'm misunderstanding something?
> > 
> > Perhaps just create a partial order that puts bss last?
> It it worth sorting things other than bss?   Don't make much difference I suppose.
Eh, probably not, but changing all the tests was a pain and I don't want to do it again :) Perhaps someone will find it useful to have similar sections together some day.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67736/new/

https://reviews.llvm.org/D67736