[PATCH] D67736: [WebAssembly] Sort output data sections to place .bss last

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Writer.cpp:690
+                     }
+                     llvm_unreachable("Unexpected segment name");
+                   });
----------------
sbc100 wrote:
> Its possible to have custom segment names.    See Writer.cpp:getOutputDataSegmentName.   Seems strange that no tests use this feature though .. maybe I'm misunderstanding something?
> 
> Perhaps just create a partial order that puts bss last?
It it worth sorting things other than bss?   Don't make much difference I suppose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67736/new/

https://reviews.llvm.org/D67736