[PATCH] D67315: [SimplifyCFG] mergeConditionalStoreToAddress(): consider cost, not instruction count

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 12:55:32 PDT 2019


Thank you for the review.

On Wed, Sep 18, 2019 at 10:54 PM James Molloy <jmolloy at google.com> wrote:
>
> If I recall correctly, I wrote the old code. And I don't think your code is any more wrong than that.
>
> On Wed, 18 Sep 2019, 20:50 Phabricator via Phabricator, <reviews at reviews.llvm.org> wrote:
>>
>> This revision was automatically updated to reflect the committed changes.
>> Closed by commit rL372255: [SimplifyCFG] mergeConditionalStoreToAddress(): consider cost, not instruction… (authored by lebedevri, committed by ).
>>
>> Changed prior to commit:
>>   https://reviews.llvm.org/D67315?vs=219230&id=220731#toc
>>
>> Repository:
>>   rL LLVM
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D67315/new/
>>
>> https://reviews.llvm.org/D67315
>>
>> Files:
>>   llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
>>   llvm/trunk/test/Transforms/SimplifyCFG/X86/merge-cond-stores-cost.ll
>>


More information about the llvm-commits mailing list