[PATCH] D67315: [SimplifyCFG] mergeConditionalStoreToAddress(): consider cost, not instruction count

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 12:54:34 PDT 2019


If I recall correctly, I wrote the old code. And I don't think your code is
any more wrong than that.

On Wed, 18 Sep 2019, 20:50 Phabricator via Phabricator, <
reviews at reviews.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL372255: [SimplifyCFG] mergeConditionalStoreToAddress():
> consider cost, not instruction… (authored by lebedevri, committed by ).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D67315?vs=219230&id=220731#toc
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67315/new/
>
> https://reviews.llvm.org/D67315
>
> Files:
>   llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
>   llvm/trunk/test/Transforms/SimplifyCFG/X86/merge-cond-stores-cost.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190918/266e955b/attachment.html>


More information about the llvm-commits mailing list