[PATCH] D67579: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups

[Rong Xu via llvm-commits]

+cc David

On Tue, Sep 17, 2019 at 3:20 PM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> From what I understand, the comdat group isn't necessary, so I disabled it
> on COFF in r372182. Can we simplify ELF to match?
>
It's probably OK without setting COMDAT for the variables in ELF as the
linkonce_odr  linkage can be used to remove the duplicates.
On the other hand, it's nature to set the COMDAT to sync the declaration of
the function.
I'm CCing david to see what is his thoughts.

-Rong

>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67579/new/
>
> https://reviews.llvm.org/D67579
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190917/e1d2e4ca/attachment.html>