[PATCH] D67617: [llvm-readobj] - Test PPC64 relocations properly.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D67617#1671483 <https://reviews.llvm.org/D67617#1671483>, @MaskRay wrote:

> Looks good, though, as a belated thought after D62594 <https://reviews.llvm.org/D62594>, I wonder if we really want to test every enum member listed in `BinaryFormat/ELFRelocs/*.def`. The source code just uses the X macros pattern to support every enum member, but we test every possibility.


I think it is good to test everything because of the following reasons.

1. We might want to check the relocation values (i.e. that declarations in .*def are correct)
2. When we add new relocations we add a test for them. Perhaps it would look not that clear why we test some of the relocations, but not other one.
3. It is just a simpler logic. I.e. testing everything is simpler here than explaining or thinking about why we do not do it :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67617/new/

https://reviews.llvm.org/D67617