[PATCH] D67617: [llvm-readobj] - Test PPC64 relocations properly.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 09:46:50 PDT 2019


MaskRay added a comment.
Herald added a subscriber: wuzish.

Looks good, though, as a belated thought after D62594 <https://reviews.llvm.org/D62594>, I wonder if we really want to test every enum member listed in `BinaryFormat/ELFRelocs/*.def`. The source code just uses the X macros pattern to support every enum member, but we test every possibility.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67617/new/

https://reviews.llvm.org/D67617





More information about the llvm-commits mailing list