[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 12:11:17 PDT 2019


lenary added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2590
 
   if (BinOp.RHS->getType()->isFPOrFPVectorTy())
     BinOp.LHS = llvm::ConstantFP::getZeroValueForNegation(BinOp.RHS->getType());
----------------
This `if` will always evaluate the false branch now, right? So you should be able to get rid of the if statement totally.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675





More information about the llvm-commits mailing list