[PATCH] D67601: TLI: Remove DAG argument from getRegisterByName

Mon Sep 16 07:46:45 PDT 2019

rengolin added a comment.

In D67601#1671349 <https://reviews.llvm.org/D67601#1671349>, @jyknight wrote:

> I think this function probably ought to be renamed. It's really not clear from its name that it's intended for such a narrow purpose -- _only_ for implementing the read_register/write_register intrinsics.

Agreed.

The "original" purpose was to work for all registers, but the read_/write_register scope shrunk a lot, and it's the only user.

If we want a generic name->register match, then we want that to be generated by table-gen. But then we still need to restrict which ones are useful, per target, for read/write.

Since we don't really need the former, I agree a rename would make more sense.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67601/new/

https://reviews.llvm.org/D67601