[PATCH] D67601: TLI: Remove DAG argument from getRegisterByName

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 07:37:45 PDT 2019


jyknight added a comment.

The code is attempting to ensure that you don't use RBP as a global register unless RBP is actually a reserved register (being used as the frame pointer in the function.) That's a reasonable goal, but maybe there's another better way to be doing it.

I think this function probably ought to be renamed. It's really not clear from its name that it's intended for such a narrow purpose -- _only_ for implementing the read_register/write_register intrinsics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67601/new/

https://reviews.llvm.org/D67601





More information about the llvm-commits mailing list