[PATCH] D65326: Fix for a dangling point bug in DeadStoreElimination pass

[Ankit via Phabricator via llvm-commits]

quic_aankit updated this revision to Diff 220335.
quic_aankit marked an inline comment as done.
quic_aankit added a comment.

Hi fhahn, sorry for the delay. I've addressed your comments. However, I was unable to add a test where multiple entries are removed from the mapping in a single deleteDeadInstructions call. The method you suggested does not work because deleting a function that may throw is not a legal operation. In the testcase that I have since it is a new function call "_Znwj", we are able to remove the call.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65326/new/

https://reviews.llvm.org/D65326

Files:
  llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
  llvm/test/Transforms/DeadStoreElimination/DeleteThrowableInst.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65326.220335.patch
Type: text/x-patch
Size: 8617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190916/2be07df5/attachment.bin>