[PATCH] D67186: [ARM] Masked loads and stores

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 15 06:25:58 PDT 2019


dmgreen marked an inline comment as done.
dmgreen added a comment.

Thanks. Sorry, I was on a bit of a bug hunt, and this is the opposite of that ;) It's behind an option though, so should be fine.



================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:494
 
+bool ARMTTIImpl::isLegalMaskedLoad(Type *DataTy) {
+  if (!EnableMaskedLoadStores || !ST->hasMVEIntegerOps())
----------------
SjoerdMeijer wrote:
> You pointed out to me that this is new, and more correct than before. ;-)
> This is what I tried to fix in the D67005, which I will abandon, because this looks good to me.
This will most likely need adjustment in the future, especially when we add narrowing/widening masked loads/stores. Hopefully OK for the time being.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67186/new/

https://reviews.llvm.org/D67186





More information about the llvm-commits mailing list