[PATCH] D67483: [ARM] Reserve an emergency spill slot for fp16 addressing modes that need it
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 13 15:20:43 PDT 2019
efriedma added a comment.
I have almost this exact change in a WIP patch, but I didn't get around to posting it because I didn't have a testcase, and I ended up deciding to handle the Thumb1 estimation differently.
================
Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1566
default:
break;
}
----------------
Can we make this "default" an "llvm_unreachable" so we don't accidentally miss addressing modes in the future, like this? (I think in that case, you'll also need to add explicit cases for debug info, AddrMode_i12, and t2ADDri?)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67483/new/
https://reviews.llvm.org/D67483
More information about the llvm-commits
mailing list