[PATCH] D67487: [CodeEmitter] Support instruction widths > 64 bits
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 13 04:35:20 PDT 2019
lebedev.ri added a comment.
> On Fri, Sep 13, 2019 at 2:03 PM James Molloy <jmolloy at google.com> wrote:
>
> Hi Roman,
>
> There is one diff to a test and one brand new test in this change (llvm/test/TableGen/BigEncoder.td).
Re test coverage: that is not really how the patch description was being read, usually that wording means something different.
> As a sidenote, your message could be considered by some unnecessarily passive-aggressive.
>
> Cheers,
>
> James
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67487/new/
https://reviews.llvm.org/D67487
More information about the llvm-commits
mailing list