[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli updated this revision to Diff 219999.
fpetrogalli added a comment.

HI @sdesmalen ,

I have updated the patch according to your feedback. In particular, I have modified all the parsing method to use the `ParseRet` enum instead of booleans. It looks better now, thanks.

Once outstanding work is the comparison operator of `VFShape`. I have proposed a solution in a comment, let me know what you think, I will apply it if you agree on the approach. BTW: good catch. The VFShape should carry information only about the shape, not about the names of the functions.

One more nit: while working on the SVFS, I have noticed that the `llvm_unreachable` I have added at the end of the static method to create FShape out of the parsed data was quite annoying: it got fired every time the CI I was trying to vectorize didn't have the name with the mangled attribute. hence, I have removed the assertion, and converted the `ASSERT_DEATH` tests into `EXPECT_FALSE` tests in `TEST(VectorFunctionABITests, OnlyValidNames)`. This should not be controversial (I am happy to be told I am wrong if that's the case).

Thank you,

Francesco


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024

Files:
  llvm/include/llvm/Analysis/VectorUtils.h
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/Analysis/VFABIDemangling.cpp
  llvm/tools/vfabi-demangle-fuzzer/CMakeLists.txt
  llvm/tools/vfabi-demangle-fuzzer/vfabi-demangler-fuzzer.cpp
  llvm/unittests/Analysis/CMakeLists.txt
  llvm/unittests/Analysis/VectorFunctionABITest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66024.219999.patch
Type: text/x-patch
Size: 38774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190912/e75c0b32/attachment.bin>